Skip to content

Promote name matches to top position + add name match badge after the package name. #8745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

Promote name matches to top position + add name match badge after the package name. #8745

merged 3 commits into from
May 15, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented May 9, 2025 •
edited
Loading

  • Previous name match block is removed.
  • The best matched name is promoted to the first spot, in certain conditions (no other active filters or sorting, but score is kept in API).
  • The "name match" badge is added after the name:
image

@isoos isoos requested review from jonasfj and sigurdm May 9, 2025 13:22
@isoos
Copy link
Collaborator Author

isoos commented May 9, 2025

Note: staging deployment is pending.

@isoos isoos force-pushed the search-name-match branch from 4689f4e to 5348995 Compare May 13, 2025 14:52
@isoos
Copy link
Collaborator Author

isoos commented May 13, 2025

PTAL. The latest version is on staging.

szakarias
szakarias approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isoos isoos merged commit 0a4c355 into dart-lang:master May 15, 2025
32 checks passed
@isoos isoos deleted the search-name-match branch May 15, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szakarias szakarias szakarias approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

@sigurdm sigurdm Awaiting requested review from sigurdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @szakarias